# Code Analysis: Wrong Rule 2131

**URL:** <https://forums.toadworld.com/t/code-analysis-wrong-rule-2131/37769>\
**Category:** Toad for Oracle - Beta\
**Created:** [May 25, 2016, 12:07am UTC](https://forums.toadworld.com/t/code-analysis-wrong-rule-2131/37769 "2016-05-25T00:07:41Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![PeterLang](https://avatars.discourse-cdn.com/v4/letter/p/71e660/32.png) [@PeterLang](https://forums.toadworld.com/u/PeterLang)\
**Post date:** [May 25, 2016, 12:07am UTC](https://forums.toadworld.com/t/code-analysis-wrong-rule-2131/37769/1 "2016-05-25T00:07:41Z")

</div>

v\_test is not a constant:

CREATE OR REPLACE PROCEDURE toad\_test AS  
TYPE test\_type IS RECORD(  
field PLS\_INTEGER  
);  
v\_test test\_type; – Rule 2131  
BEGIN  
v\_test.field := 1;  
END;

---

<div class="post-metadata">

**Author:** ![avergison](https://sea1.discourse-cdn.com/quest/user_avatar/forums.toadworld.com/avergison/32/66_2.png) [@avergison](https://forums.toadworld.com/u/avergison)\
**Post date:** [May 25, 2016, 10:46am UTC](https://forums.toadworld.com/t/code-analysis-wrong-rule-2131/37769/2 "2016-05-25T10:46:08Z")

</div>

Does the following work better?

//VAR\_DECL [not(…//ASSIGN/LHS/QNAME/IDENTIFIER[1]/@value = QNAME/@value)]

[not(…//INTO\_LIST/QNAME/IDENTIFIER[1]/@value = QNAME/@value)]

[not(…//PARAM/QNAME/IDENTIFIER[1]/@value = QNAME/@value)]

/QNAME

Here we look for variables as the leftmost symbol in dotted series of symbols which never get data assigned.

Andre

---

<div class="post-metadata">

**Author:** ![PeterLang](https://avatars.discourse-cdn.com/v4/letter/p/71e660/32.png) [@PeterLang](https://forums.toadworld.com/u/PeterLang)\
**Post date:** [June 6, 2016, 12:12am UTC](https://forums.toadworld.com/t/code-analysis-wrong-rule-2131/37769/3 "2016-06-06T00:12:41Z")

</div>

It works as expected for the cases I tested. Thanks!

This does not trigger the rule any more (correct):  
v\_test.field := 1;

This still triggers the rule (correct):  
IF( v\_test.field = 1 ) THEN  
NULL;  
END IF;

Old rule for reference:  
//VAR\_DECL [not(…//ASSIGN/LHS/QNAME/@value = QNAME/@value)]  
[not(…//INTO\_LIST/QNAME/@value = QNAME/@value)]  
[not(…//PARAM/QNAME/@value = QNAME/@value)]  
/QNAME

---

<div class="post-metadata">

**Author:** ![avergison](https://sea1.discourse-cdn.com/quest/user_avatar/forums.toadworld.com/avergison/32/66_2.png) [@avergison](https://forums.toadworld.com/u/avergison)\
**Post date:** [June 6, 2016, 12:43am UTC](https://forums.toadworld.com/t/code-analysis-wrong-rule-2131/37769/4 "2016-06-06T00:43:02Z")

</div>

Thanks Peter for your testing effort. I’ll add the new expression to the Toad rule universe.

Andre
