Toad World® Forums

Code review 123 error


#1

First some code snip

    IF lrt_process.status IN ('I', 'O')
    THEN
        IF NOT util.is_integer (pi_pond_obj)
            OR NOT util.is_integer (pi_pond_comp)
        THEN
            RAISE e_erro_pond;
        END IF;

        IF (pi_pond_obj
             + pi_pond_comp) != 100
        THEN
            RAISE e_erro_pond;
        END IF;

        IF lrt_process.tipo IN ('2007S2', '2007S3')

/*ADVICE(3517): This point cannot be reached (dead code) [123] */
/*ADVICE(3518): This point cannot be reached (dead code) [123] */
/*ADVICE(3519): This point cannot be reached (dead code) [123] */
/*ADVICE(3520): This point cannot be reached (dead code) [123] */
THEN
UPDATE process
/*ADVICE(3523): This point cannot be reached (dead code) [123] */
SET ponderacao = pi_pond_obj+ ponderacao_competencias
/*ADVICE(3525): This point cannot be reached (dead code) [123] */
/*ADVICE(3526): This point cannot be reached (dead code) [123] */
WHERE id = pct_id;
/*ADVICE(3528): This point cannot be reached (dead code) [123] */
END IF;
END IF;


Its very strange why the 123 warning is raised …
But even more strange is the duplication of the ADVICES

Thanks
Filipe Silva


#2

I forgot to mention that that occurs with 6.1 version


#3

Filipe,

The current advisor has some bugs, we all know. A new one is in the making …

Thanks,
Andre