Toad World® Forums

Formatter: code review 513


#1

Hi
First some code

(…)
WHEN OTHERS
/*ADVICE(163): This function exception handler does not contain a RETURN
statement [513] */
THEN
IF SQLCODE BETWEEN -1899
AND -1800
THEN
RETURN FALSE;
ELSE
RAISE;
END IF;
end;

that code review should not be triggered (I think) if there is a return or raise in every escape.

for instance the in next two examples the code review doesn’t appear (and that’s correct)
(…)
WHEN OTHERS
THEN
RAISE;
end;

and also

*WHEN OTHERS
THEN
IF SQLCODE BETWEEN -1899
AND -1800
THEN
RETURN FALSE;
END IF;

    RAISE;

end;*

Thanks

Filipe


#2

Hi Filipe,

Thanks for pointing this out. I agree with you. I will raise CR for this.
Sorry for the late response.

Thanks,
Vincent