Formatter Anomaly

Toad for Oracle - Beta
1

The formatter seems to shift everything 3 indention levels to the right when the From includes and XMLTable with 2 Columns.

Here is Case 1 showing the over indention:

image
image713×235 18.1 KB

Here is Case 2 where I uncomment line 9 and comment out 10-11 so only 1 column is returned:
image

Lastly here is what I get if I then comment out line 9 and 11 leaving 10 so in theory a single column:

image
image709×254 20.5 KB

Here is the SQL:
Sample.txt (743 Bytes)

If I should report Formatter items in some other way, let me know. I use the Toad Beta for all my work, so have not tried this in 15.1 .

Here are my Formatter Options if needed:

<FormatterOptions>
  <Version>296</Version>
  <LegacyOptionsGUI>5.327.0</LegacyOptionsGUI>
  <QP5>5.381</QP5>
  <RightMargin>80</RightMargin>
  <AssignAlignment>2</AssignAlignment>
  <AssignAlignmentDynMinSpace>1</AssignAlignmentDynMinSpace>
  <CommaStyle>2</CommaStyle>
  <ParensStyle>2</ParensStyle>
  <AndOrStyle>1</AndOrStyle>
  <AndOrOperatorPos>2</AndOrOperatorPos>
  <ConcatStyle>1</ConcatStyle>
  <CaseAllowFlat>0</CaseAllowFlat>
  <JoinOnNewLine>1</JoinOnNewLine>
  <ParenthesizedQueryAsBlock>1</ParenthesizedQueryAsBlock>
  <DefaultArrangeOnCol>2</DefaultArrangeOnCol>
  <DefaultListParens>1</DefaultListParens>
  <DefaultOverflowListParens>1</DefaultOverflowListParens>
  <TableRefArrangement>S</TableRefArrangement>
  <TableRefArrangeOnCol>1</TableRefArrangeOnCol>
  <ExprArrangeOnCol>99</ExprArrangeOnCol>
</FormatterOptions>
2

Hello Michael,

It looks as if the size of the column name (ATTRIBUTE_NAME for instance) shifts the result towards the right. The longer the name, the more it shifts to the right.

I queued this case (QP-3956).

Thanks for your report!
Andre

3

Hello Michael,

This one got fixed, finally. The flaw did affect all DML statements, whenever column definitions appeared inside the statement. Formatter tried to align those definitions, and that alignment messed up the outer alignment of the top level clauses.

Sorry about the long delay, it required some deep diving into the code. But I hope you'll be glad it got fixed.

It will show up in component QP5.dll as of version 5.419.

Thanks,
Andre

1 Like